[Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

[Brian Paul]

On 06/09/2016 09:35 AM, Brian Paul wrote:
> On 06/08/2016 11:03 PM, Mathias.Froehlich at gmx.net wrote:
>> From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
>>
>> Hi all,
>>
>> I just put the two leading patches to move u_bit_scan
>> from gallium to util. The architecture handling of
>> ffs{,ll} is merged with what is available in the
>> mesa/util directory. It compiles and works here and
>> we should get slightly better intrinsic coverage on win32.
>> At least according to what is documented at msdn. But
>> the chance to break one of our other builds or
>> architectures is high with this kind of change.
>> So any hints or testing according that are
>> even more appreciated.
>>
>> The rest of the series posted earlier gets posted
>> again when this part arrived.
>>
>> Please review.
>
> I'm getting a compilation error on MSVC.  Will try to debug it today...

I think we just need to #include "c99_compat.h" in bitscan.h so that the 
inline keyword gets defined.

-Brian

> -Brian
>
>>
>> Thanks
>>
>> Mathias
>>
>> Mathias Fröhlich (2):
>>    mesa/gallium: Move u_bit_scan{,64} from gallium to mesa.
>>    mesa: Make use of u_bit_scan{,64}.
>>
>>   src/gallium/auxiliary/util/u_math.h | 149
>> +----------------------------------
>>   src/mesa/main/arrayobj.c            |   6 +-
>>   src/mesa/main/buffers.c             |   4 +-
>>   src/mesa/main/imports.c             |  58 --------------
>>   src/mesa/main/imports.h             |  16 ----
>>   src/util/Makefile.sources           |   2 +
>>   src/util/bitscan.c                  |  80 +++++++++++++++++++
>>   src/util/bitscan.h                  | 151
>> ++++++++++++++++++++++++++++++++++++
>>   8 files changed, 239 insertions(+), 227 deletions(-)
>>   create mode 100644 src/util/bitscan.c
>>   create mode 100644 src/util/bitscan.h
>>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev