[Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

Brian Paul brianp at vmware.com
Thu Jun 9 18:35:52 UTC 2016


On 06/09/2016 12:10 PM, Brian Paul wrote:
> On 06/09/2016 09:35 AM, Brian Paul wrote:
>> On 06/08/2016 11:03 PM, Mathias.Froehlich at gmx.net wrote:
>>> From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
>>>
>>> Hi all,
>>>
>>> I just put the two leading patches to move u_bit_scan
>>> from gallium to util. The architecture handling of
>>> ffs{,ll} is merged with what is available in the
>>> mesa/util directory. It compiles and works here and
>>> we should get slightly better intrinsic coverage on win32.
>>> At least according to what is documented at msdn. But
>>> the chance to break one of our other builds or
>>> architectures is high with this kind of change.
>>> So any hints or testing according that are
>>> even more appreciated.
>>>
>>> The rest of the series posted earlier gets posted
>>> again when this part arrived.
>>>
>>> Please review.
>>
>> I'm getting a compilation error on MSVC.  Will try to debug it today...
>
> I think we just need to #include "c99_compat.h" in bitscan.h so that the
> inline keyword gets defined.
>

And #include bitscan.h in prog_print.c where ffs() is used but not  found.

-Brian



More information about the mesa-dev mailing list