[Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Tue Jun 14 04:42:25 UTC 2016


Hi Brian,

On Friday, June 10, 2016 12:41:29 Brian Paul wrote:
> Long term, I'd like to get away from imports.h defining or including a 
> bunch of stuff that a lot of .c files don't need.  So I'd prefer to 
> include bitscan.h where needed, but I agree with your concerns.
In that case, ideally we would also have a u_ffs then so that missing includes
get detected early.

> The patch as you have it now is fine.  I tested it with MSVC.
Pushed this part now. Thanks for review and testing.

> I see there's some _mesa_fsl() functions still in imports.h.  I think 
> those should probably go into bitscan.h too.  A follow-on commit would 
> be OK.
Ok.

Thanks

Mathias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160614/fd9c0a14/attachment.html>


More information about the mesa-dev mailing list