[Mesa-dev] [PATCH v2] swr: automake: don't ship LLVM version specific generated sources

[Emil Velikov]

On 14 June 2016 at 18:06, Rowley, Timothy O <timothy.o.rowley at intel.com> wrote:
>
>> On Jun 13, 2016, at 8:03 PM, Rowley, Timothy O <timothy.o.rowley at intel.com> wrote:
>>
>> A clean tree build works with this version, but distcheck fails:
>>
>> ...
>> rm -f config.status config.cache config.log configure.lineno config.status.lineno
>> rm -f Makefile
>> ERROR: files left in build directory after distclean:
>> ./src/gallium/drivers/swr/rasterizer/jitter/builder_gen.cpp
>> ./src/gallium/drivers/swr/rasterizer/jitter/builder_x86.cpp
>> ./src/gallium/drivers/swr/rasterizer/jitter/builder_gen.h
>> make[1]: *** [distcleancheck] Error 1
>> make[1]: Leaving directory `/home/torowley/work/mesa-opt/mesa-12.1.0-devel/_build'
>> make: *** [distcheck] Error 1
>>
>> Not sure how builder_x86.cpp managed to change its status.
>
> To answer my own question: the reason for builder_x86.cpp being regenerated is because of its dependency on builder_gen.h (through builder.h).
>
I thought that one was mentioned is the big comment in the patch.
Perhaps my wording could be improved - any suggestions ?

And yes, due to the missing dependency the file will be (re)generated
at a later stage thus we'll need to add yet another workaround for
that. Just listing the whole lot in CLEANFILES should be enough.

Feel free to give it a try, or I'll do at some point later on today.

Thanks,
Emil