[Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields

Chad Versace chad.versace at intel.com
Thu Jun 16 17:14:22 UTC 2016


On Sat 11 Jun 2016, Jason Ekstrand wrote:
> They're already zero-initialized and we have no plans of doing anything
> more interesting with them.
> ---
>  src/intel/isl/isl_surface_state.c | 9 ---------
>  1 file changed, 9 deletions(-)



> @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
>     s.MultisampledSurfaceStorageFormat =
>        isl_to_gen_multisample_layout[info->surf->msaa_layout];
>     s.NumberofMultisamples = ffs(info->surf->samples) - 1;
> -   s.MultisamplePositionPaletteIndex = 0; /* UNUSED */
> -
> -   s.XOffset = 0;
> -   s.YOffset = 0;

Wait. Seriously? i965 no longer uses XOffset/YOffset on *any* gen!?!?!?
When did that happen? I've been waiting for years for i965 to stop using
XOffset/YOffset on old hardware, but obviously I wasn't paying enough
attention to the git logs.


More information about the mesa-dev mailing list