[Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields

[Jason Ekstrand]

On Thu, Jun 16, 2016 at 10:14 AM, Chad Versace <chad.versace at intel.com>
wrote:

> On Sat 11 Jun 2016, Jason Ekstrand wrote:
> > They're already zero-initialized and we have no plans of doing anything
> > more interesting with them.
> > ---
> >  src/intel/isl/isl_surface_state.c | 9 ---------
> >  1 file changed, 9 deletions(-)
>
>
>
> > @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const struct isl_device
> *dev, void *state,
> >     s.MultisampledSurfaceStorageFormat =
> >        isl_to_gen_multisample_layout[info->surf->msaa_layout];
> >     s.NumberofMultisamples = ffs(info->surf->samples) - 1;
> > -   s.MultisamplePositionPaletteIndex = 0; /* UNUSED */
> > -
> > -   s.XOffset = 0;
> > -   s.YOffset = 0;
>
> Wait. Seriously? i965 no longer uses XOffset/YOffset on *any* gen!?!?!?
> When did that happen? I've been waiting for years for i965 to stop using
> XOffset/YOffset on old hardware, but obviously I wasn't paying enough
> attention to the git logs.
>

Nope.  Further on I add them back in for real.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160616/aff06038/attachment.html>