[Mesa-dev] [PATCH 13/64] isl/state: Put all dimension setup together and towards the top

[Chad Versace]

On Sat 11 Jun 2016, Jason Ekstrand wrote:
> ---
>  src/intel/isl/isl_surface_state.c | 154 ++++++++++++++++++--------------------
>  1 file changed, 74 insertions(+), 80 deletions(-)
> 
> diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
> index 0f21e34..0ada3e4 100644
> --- a/src/intel/isl/isl_surface_state.c
> +++ b/src/intel/isl/isl_surface_state.c
> @@ -213,7 +213,81 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
>        s.SurfaceFormat = info->view->format;
>     }
>  
> +   s.Width = info->surf->logical_level0_px.width - 1;
> +   s.Height = info->surf->logical_level0_px.height - 1;
> +
> +   switch (s.SurfaceType) {
> +   case SURFTYPE_1D:
> +   case SURFTYPE_2D:
> +      s.MinimumArrayElement = info->view->base_array_layer;

Small nitpick. You can move s.MinimumArrayElement out of the switch, as
each case assigns the same value. Ignore this if you wish.

Patches 12 and 13 are
Reviewed-by: Chad Versace <chad.versace at intel.com>