[Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

[Grazvydas Ignotas]

On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote:
>> On Sun, 2016-06-26 at 16:15 +0300, Grazvydas Ignotas wrote:
>> > Tried this while playing with apitrace and am getting segfaults
>> > when
>> > running any trace with a cached (second) run. Not sure if it's
>> > "wrong"
>> > traces I've chosen or what, you can take one example from this bug:
>> > https://bugs.freedesktop.org/show_bug.cgi?id=96425
>>
>> Thanks for testing I'll take a look tomorrow.
>
> The problem is the shaders were being detached after linking so we had
> nothing to fallback to if we had a shade cache miss.
> I've hacked something up and pushed it to the shader-cache19 branch
> that allows the trace to run. Not sure how it relates to real game
> performance but the trace goes from 5FPS to 7FPS on the second run on
> my machine with which looks good :)

Seems to work now and makes things a good deal faster. nice!

However I have a case of one trace's cache seemingly affecting another
trace, are you interested in that? One of them (the one that gets
broken) is from this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=92229
Unfortunately the other "bad" one is my own and is over a gigabyte
(even compressed), I'll need to trim it I guess.

>> > It would also be good idea to hide the cache debug messages behind
>> > some env var, or at least send them to stderr and not stdout, as
>> > stdout breaks programs that pipe data through stdout like
>> > qapitrace.
>>
>> Right thats my next task, I should get this done tomorrow also. As
>> stated below :) "For now I have left in some printf's as the feature
>> is
>> still disabled by default and they are useful for debugging. I intend
>> to fix this soon to hide them behind an environment var."

Yes I have read that (even used your wording in my comment), but
somehow managed to forget it while testing, sorry.

Gražvydas