[Mesa-dev] [PATCH v2 31/34] i965/state: Account for the element size in emit_buffer_surface_state

Pohjolainen, Topi topi.pohjolainen at intel.com
Wed Jun 29 05:27:39 UTC 2016


On Tue, Jun 28, 2016 at 09:22:49AM +0300, Pohjolainen, Topi wrote:
> On Thu, Jun 23, 2016 at 02:00:30PM -0700, Jason Ekstrand wrote:
> > ---
> >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c  | 11 ++++++-----
> >  src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |  9 +++++----
> >  src/mesa/drivers/dri/i965/gen8_surface_state.c    |  9 +++++----
> >  3 files changed, 16 insertions(+), 13 deletions(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > index 944d64d..29b8976 100644
> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > @@ -496,6 +496,7 @@ gen4_emit_buffer_surface_state(struct brw_context *brw,
> >                                 unsigned pitch,
> >                                 bool rw)
> >  {
> > +   unsigned elements = buffer_size / pitch;
> 
> Could be const as well as in the two other occurences further down.

Otherwise patches 31-34 are also:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>


More information about the mesa-dev mailing list