[Mesa-dev] ARB_gpu_shader_int64 second posting (softpipe/llvmpipe/radeonsi)

[Ian Romanick]

Patches 1, 2, 3, 4 (with the changes you said you made), 6, 7, 8, 11,
12, and 14 through 19 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I sent comments on 5 and 10.

9 was already R-b.

I'm still thinking about 13, but it's probably correct.

I'm a little surprised that nothing was needed for UBOs or SSBOs.  I
guess the code is generic enough that, as long as glsl_type gives
correct sizes, it just works.

On 06/19/2016 10:06 PM, Dave Airlie wrote:
> Okay this is the second posting for the ARB_gpu_shader_int64 series.
> 
> This adds support for the conversion and plumbs the necessary ones
> down through gallium and into the drivers. It documents the gallium
> opcodes as well.
> 
> I haven't taken Ian's advice to macroise the GLSL constant
> expression stuff yet, that should probably be done after this series
> as a separate cleanup.
> 
> It's all on my arb_gpu_shader_int64 branch. The radeonsi patch
> is experimental so far, it worked in an earlier test run, but I
> haven't ran it on my radeonsi since. However I've tests softpipe
> and llvmpipe pass all the piglit tests I've written so far. (They
> are on my arb_gpu_shader_int64 piglit branch).
> 
> Dave.
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>