[Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

[Andres Gomez]

On Thu, 2016-06-30 at 10:55 +1000, Timothy Arceri wrote:
> On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote:
> > The linker deals with atomic counters in terms of uniforms. This is
> > OK
> > but when we want to know the number of used atomic counters since a
> > 2
> > elements atomic counters array will use 2 counters but only 1
> > uniform.
> 
> You don't really mention what you are changing. How about:
> 
> glsl: count atomic counters correctly.
> 
> Currently the linker uses the uniform count for the total number of
> atomic counters. However uniforms don't include the innermost array
> dimension in their count, but atomic counters are expected to include
> them.
> 
> <insert supporting spec quote??>
> 
> Fixes GL44-CTS.arrays_of_arrays_gl.AtomicDeclaration

Sounds good. Thanks, I will use it.

> 
> > 
> > Renamed the data structures used in the linker for disambiguation.
> 
> You should really have split this in two. One patch to rename things
> and one to change make the actual change.
> 
> If you fix up the commit message then you can add:
> 
> Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
> 
> I'd also rather you split this into two patches before pushing but I
> can live with it if you don't.

That makes sense. I will split into 2 commits before pushing.

Thanks for the review!

-- 

Br,

Andres