[Mesa-dev] [PATCH 1/2] i965: Reduce the SIMD8 GS push constant threshold from 32 to 24.

[Rhys Kidd]

Hello Kenneth,

On 10 May 2016 at 03:46, Kenneth Graunke <kenneth at whitecape.org> wrote:

> Three Shadow of Mordor geometry shaders increase by a single
> instruction, but the number of spills/fills in Orbital Explorer
> is reduced from 194:1279 -> 82:454.  No other programs are affected.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index ce3e00b..332e382 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -5155,7 +5155,7 @@ fs_visitor::setup_gs_payload()
>     }
>
>     /* Use a maximum of 32 registers for push-model inputs. */
>

Can you please update this comment for the changed number of registers?


> -   const unsigned max_push_components = 32;
> +   const unsigned max_push_components = 24;
>
>
    /* If pushing our inputs would take too many registers, reduce the URB
> read
>      * length (which is in HWords, or 8 registers), and resort to pulling.
> --
> 2.8.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160510/29f81765/attachment.html>