[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98172

--- Comment #19 from Michel Dänzer <michel at daenzer.net> ---
(In reply to shinji.suzuki from comment #16)
> Created attachment 127317 [details] [review]
> Arbitration on so->fence through per sync-object mutex.

One minor comment below, otherwise looks good to me. Feel free to submit the
patch generated by git format-patch to the mesa-dev mailing list for review.


+   if (type == GL_SYNC_FENCE) {
+      struct st_sync_object * so = 
+         (struct st_sync_object*)CALLOC_STRUCT(st_sync_object);
+      mtx_init(&so->mtx, mtx_plain);
+      return (struct gl_sync_object *)so;
+   } else
       return NULL;

This can be written as:

   if (type == GL_SYNC_FENCE) {
      [...]
   }

   return NULL;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161017/e01626f6/attachment-0001.html>