[Mesa-dev] [PATCH] nir: fix definition of pack_uvec2_to_uint

Jason Ekstrand jason at jlekstrand.net
Mon Sep 5 03:55:37 UTC 2016


Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

But definitely not tested-by :-)

On Sun, Sep 4, 2016 at 7:47 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:

> Found by inspection. Untested beyond compilation.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/compiler/nir/nir_opcodes.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_
> opcodes.py
> index 15066c2..7045c95 100644
> --- a/src/compiler/nir/nir_opcodes.py
> +++ b/src/compiler/nir/nir_opcodes.py
> @@ -257,7 +257,7 @@ unpack_4x8("unorm")
>  unpack_2x16("half")
>
>  unop_horiz("pack_uvec2_to_uint", 1, tuint32, 2, tuint32, """
> -dst.x = (src0.x & 0xffff) | (src0.y >> 16);
> +dst.x = (src0.x & 0xffff) | (src0.y << 16);
>  """)
>
>  unop_horiz("pack_uvec4_to_uint", 1, tuint32, 4, tuint32, """
> --
> 2.7.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160904/8ee67fd8/attachment.html>


More information about the mesa-dev mailing list