[Mesa-dev] [PATCH 2/9] i915: take ownership rather than adding reference for new renderbuffers

Timothy Arceri tarceri at itsqueeze.com
Sat Apr 8 01:31:46 UTC 2017


<snip/>

Sorry the below change was meant to be squashed into the previous patch. 
Fixed locally.

> --- a/src/mesa/main/renderbuffer.c
> +++ b/src/mesa/main/renderbuffer.c
> @@ -106,23 +106,23 @@ _mesa_delete_renderbuffer(struct gl_context *ctx, struct gl_renderbuffer *rb)
>
>
>  /**
>   * Attach a renderbuffer to a framebuffer.
>   * \param bufferName  one of the BUFFER_x tokens
>   *
>   * This function avoids adding a reference and is therefore intended to be
>   * used with a freashly created renderbuffer.
>   */
>  void
> -_mesa_attach_renderbuffer_without_ref(struct gl_framebuffer *fb,
> -                                      gl_buffer_index bufferName,
> -                                      struct gl_renderbuffer *rb)
> +_mesa_add_renderbuffer_without_ref(struct gl_framebuffer *fb,
> +                                   gl_buffer_index bufferName,
> +                                   struct gl_renderbuffer *rb)
>  {
>     assert(fb);
>     assert(rb);
>     assert(bufferName < BUFFER_COUNT);
>
>     /* There should be no previous renderbuffer on this attachment point,
>      * with the exception of depth/stencil since the same renderbuffer may
>      * be used for both.
>      */
>     assert(bufferName == BUFFER_DEPTH ||
>


More information about the mesa-dev mailing list