[Mesa-dev] [PATCH] mesa: remove wip framebuffer code

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Apr 27 11:35:04 UTC 2017


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 04/27/2017 01:07 PM, Timothy Arceri wrote:
> This was added in 34b3b40af97d back in 2006. Seems it wasn't
> needed.
> ---
>   src/mesa/main/framebuffer.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c
> index 9002020..5069d37 100644
> --- a/src/mesa/main/framebuffer.c
> +++ b/src/mesa/main/framebuffer.c
> @@ -467,27 +467,20 @@ _mesa_update_draw_buffer_bounds(struct gl_context *ctx,
>    */
>   void
>   _mesa_update_framebuffer_visual(struct gl_context *ctx,
>   				struct gl_framebuffer *fb)
>   {
>      GLuint i;
>   
>      memset(&fb->Visual, 0, sizeof(fb->Visual));
>      fb->Visual.rgbMode = GL_TRUE; /* assume this */
>   
> -#if 0 /* this _might_ be needed */
> -   if (fb->_Status != GL_FRAMEBUFFER_COMPLETE_EXT) {
> -      /* leave visual fields zero'd */
> -      return;
> -   }
> -#endif
> -
>      /* find first RGB renderbuffer */
>      for (i = 0; i < BUFFER_COUNT; i++) {
>         if (fb->Attachment[i].Renderbuffer) {
>            const struct gl_renderbuffer *rb = fb->Attachment[i].Renderbuffer;
>            const GLenum baseFormat = _mesa_get_format_base_format(rb->Format);
>            const mesa_format fmt = rb->Format;
>   
>            /* Grab samples and sampleBuffers from any attachment point (assuming
>             * the framebuffer is complete, we'll get the same answer from all
>             * attachments).
> 


More information about the mesa-dev mailing list