[Mesa-dev] [PATCH 1/2] gallium/radeon: sort DBG shader flags according to pipe_shader_type

[Marek Olšák]

On Wed, Aug 30, 2017 at 11:19 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Marek,
>
> There's a couple of subtle changes in the patch. If intentional, could
> you mention that in the commit message?
>
> On 29 August 2017 at 23:25, Marek Olšák <maraeo at gmail.com> wrote:
>
>>  static void r600_disk_cache_create(struct r600_common_screen *rscreen)
>>  {
>>         /* Don't use the cache if shader dumping is enabled. */
>> -       if (rscreen->debug_flags &
>> -           (DBG_FS | DBG_VS | DBG_TCS | DBG_TES | DBG_GS | DBG_PS | DBG_CS))
>> +       if (rscreen->debug_flags & DBG_ALL_SHADERS)
> DBG_FS seems to be missing now.

DBG_FS is a shader in r600, and r600 doesn't use the shader cache.

>
>
>> --- a/src/gallium/drivers/radeonsi/si_pipe.c
>> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
>> @@ -364,22 +364,21 @@ static struct pipe_context *si_pipe_create_context(struct pipe_screen *screen,
>
>> -       if (sscreen->b.debug_flags & (DBG_VS | DBG_TCS | DBG_TES | DBG_GS |
>> -                                     DBG_PS | DBG_CS))
>> +       if (sscreen->b.debug_flags & DBG_ALL_SHADERS)
> Considering all the other places have DBG_FS (sort of) shouldn't there
> be one here as well?

This is not the r600 driver.

>
>
>> @@ -1077,21 +1076,21 @@ struct pipe_screen *radeonsi_screen_create(struct radeon_winsys *ws,
>
>>         if (debug_get_bool_option("RADEON_DUMP_SHADERS", false))
>> -               sscreen->b.debug_flags |= DBG_FS | DBG_VS | DBG_GS | DBG_PS | DBG_CS;
>> +               sscreen->b.debug_flags |= DBG_ALL_SHADERS;
> DBG_FS is now missing while TCS and TES are newly added.

This is not the r600 driver. That environment variable is also deprecated.

Marek