[Mesa-dev] [PATCH 1/2] gallium/radeon: sort DBG shader flags according to pipe_shader_type

[Marek Olšák]

On Wed, Aug 30, 2017 at 12:50 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 30 August 2017 at 10:38, Marek Olšák <maraeo at gmail.com> wrote:
>> On Wed, Aug 30, 2017 at 11:19 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Hi Marek,
>>>
>>> There's a couple of subtle changes in the patch. If intentional, could
>>> you mention that in the commit message?
>>>
>>> On 29 August 2017 at 23:25, Marek Olšák <maraeo at gmail.com> wrote:
>>>
>>>>  static void r600_disk_cache_create(struct r600_common_screen *rscreen)
>>>>  {
>>>>         /* Don't use the cache if shader dumping is enabled. */
>>>> -       if (rscreen->debug_flags &
>>>> -           (DBG_FS | DBG_VS | DBG_TCS | DBG_TES | DBG_GS | DBG_PS | DBG_CS))
>>>> +       if (rscreen->debug_flags & DBG_ALL_SHADERS)
>>> DBG_FS seems to be missing now.
>>
>> DBG_FS is a shader in r600, and r600 doesn't use the shader cache.
>>
> Right, thanks for the corrections.
>
> Am I seeing it correctly, that on r600 cache files will be created
> even though they're unused? Worth avoiding the creation since it's a
> bit misleading/confusing?

Probably. We are thinking about abandoning drivers/radeon and copying
that into r600 and radeonsi to put an end to the code sharing.

Marek