[Mesa-dev] [PATCH v2 19/25] mesa/glspirv: Add a _mesa_spirv_link_shaders() placeholder

[Timothy Arceri]

On 07/12/17 20:59, Eduardo Lima Mitev wrote:
> On 12/07/2017 05:51 AM, Timothy Arceri wrote:
>> Please squash this with patch 22 tis is just code churn.
>>
> 
> Ok, this makes sense, though I will have to re-order a bit the patches
> to keep each single one building fine.

None of the patches in between seem to use it so it should be fine

> 
> I the squashed result would keep your R-b from patch 22, right?

Correct :)

> 
> thnaks,
> Eduardo
> 
>> On 01/12/17 04:28, Eduardo Lima Mitev wrote:
>>> This will be the equivalent to link_shaders() from
>>> src/compiler/glsl/linker.cpp, but for SPIR-V programs.
>>> ---
>>>    src/mesa/main/glspirv.c | 10 ++++++++++
>>>    src/mesa/main/glspirv.h |  4 ++++
>>>    2 files changed, 14 insertions(+)
>>>
>>> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
>>> index 18710c0d8fc..e533853f7fa 100644
>>> --- a/src/mesa/main/glspirv.c
>>> +++ b/src/mesa/main/glspirv.c
>>> @@ -104,6 +104,16 @@ _mesa_spirv_shader_binary(struct gl_context *ctx,
>>>       }
>>>    }
>>>    +void
>>> +_mesa_spirv_link_shaders(struct gl_context *ctx, struct
>>> gl_shader_program *prog)
>>> +{
>>> +   /* @TODO: This is a placeholder for the equivalent of
>>> +    * compiler/glsl/linker.cpp::link_shaders() but for SPIR-V.
>>> +    */
>>> +   prog->data->LinkStatus = linking_success;
>>> +   prog->data->Validated = false;
>>> +}
>>> +
>>>    void GLAPIENTRY
>>>    _mesa_SpecializeShaderARB(GLuint shader,
>>>                              const GLchar *pEntryPoint,
>>> diff --git a/src/mesa/main/glspirv.h b/src/mesa/main/glspirv.h
>>> index ba281f68bef..0f03b75c111 100644
>>> --- a/src/mesa/main/glspirv.h
>>> +++ b/src/mesa/main/glspirv.h
>>> @@ -76,6 +76,10 @@ _mesa_spirv_shader_binary(struct gl_context *ctx,
>>>                              unsigned n, struct gl_shader **shaders,
>>>                              const void* binary, size_t length);
>>>    +void
>>> +_mesa_spirv_link_shaders(struct gl_context *ctx,
>>> +                         struct gl_shader_program *prog);
>>> +
>>>    /**
>>>     * \name API functions
>>>     */
>>>
>>
>