[Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

Kai Wasserbäch kai at dev.carbon-project.org
Fri Jan 6 21:14:59 UTC 2017


Hey Pierre,
this looks like it went to the wrong list. radv patches should be sent to
<mailto:mesa-dev at lists.freedesktop.org> AFAIK (CCed with this message).

Cheers,
Kai


Pierre-Loup A. Griffais wrote on 06.01.2017 21:57:
> Interpreting layerCount literally would try to create billions of image
> views in radv_process_depth_image_inplace().
> 
> Signed-off-by: Pierre-Loup A. Griffais <pgriffais at valvesoftware.com>
> ---
>  src/amd/vulkan/radv_meta_decompress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_decompress.c b/src/amd/vulkan/radv_meta_decompress.c
> index 47ef64d..9f262e6 100644
> --- a/src/amd/vulkan/radv_meta_decompress.c
> +++ b/src/amd/vulkan/radv_meta_decompress.c
> @@ -382,7 +382,7 @@ static void radv_process_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
>  
>  	radv_meta_save_graphics_reset_vport_scissor(&saved_state, cmd_buffer);
>  
> -	for (uint32_t layer = 0; layer < subresourceRange->layerCount; layer++) {
> +	for (uint32_t layer = 0; layer < radv_get_layerCount(image, subresourceRange); layer++) {
>  		struct radv_image_view iview;
>  
>  		radv_image_view_init(&iview, cmd_buffer->device,
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170106/49ce626a/attachment.sig>


More information about the mesa-dev mailing list