[Mesa-dev] [PATCH 3/3] anv/image: Disable HiZ for depth buffer arrays

[Jason Ekstrand]

2017-01-06 14:46 GMT-08:00 Nanley Chery <nanleychery at gmail.com>:

> We currently don't perform clears or resolves on multiple array layers
> with HiZ.
>

Glancing through the code, it looks like you're right.  I'm not even sure
that you can do layered HiZ clears and/or resolves with the HZ op; you'd
probably have to do it the gen7 way with blorp.  Thanks for catching this!


> Cc: mesa-stable at lists.freedesktop.org


Do we have hiz in 13.1?  If not, it won't apply and Emil will reject it.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


>
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_image.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index e60373a151..f262d8a524 100644
> --- a/src/intel/vulkan/anv_image.c
> +++ b/src/intel/vulkan/anv_image.c
> @@ -186,6 +186,8 @@ make_surface(const struct anv_device *dev,
>           anv_finishme("Implement gen7 HiZ");
>        } else if (vk_info->mipLevels > 1) {
>           anv_finishme("Test multi-LOD HiZ");
> +      } else if (vk_info->arrayLayers > 1) {
> +         anv_finishme("Implement multi-arrayLayer HiZ clears and
> resolves");
>        } else if (dev->info.gen == 8 && vk_info->samples > 1) {
>           anv_finishme("Test gen8 multisampled HiZ");
>        } else {
> --
> 2.11.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170106/76887795/attachment.html>