[Mesa-dev] [PATCH] drirc: Allow extension midshader for Divinity: Original Sin (EE)

[Kai Wasserbäch]

Hey Marek,
Marek Olšák wrote on 07.01.2017 15:48:
> Pushed.

thanks a lot!

> Can you close the bugs if it's fixed?

It is not, as you can read in a more concise form (all the info is also in the
bug report) at
<https://steamcommunity.com/app/373420/discussions/0/353915309344847166/> the
midshader extension is just one part needed to make Divinity run (in the
meantime this affects amdgpu-pro users as well, see the end of the discussion in
the Steam community forums!). On the other hand I do not believe Mesa would want
to work around these issues by implementing (a shim version of)
ARB_shading_language_include and setting „ATI Technologies, Inc.“ as the OpenGL
vendor string. So maybe it would be best to close that bug as WONTFIX, include
the link to the Steam Community forum? But that's better to be decided by a
developer more involved in Mesa, I think.

Cheers,
Kai


> On Sat, Jan 7, 2017 at 2:38 PM, Kai Wasserbäch
> <kai at dev.carbon-project.org> wrote:
>> See also <https://bugs.freedesktop.org/show_bug.cgi?id=93551#c27> where
>> this was first observed as a requirement.
>>
>> Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
>> ---
>>  src/mesa/drivers/dri/common/drirc | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc
>> index af84ee82e8..798283fd3e 100644
>> --- a/src/mesa/drivers/dri/common/drirc
>> +++ b/src/mesa/drivers/dri/common/drirc
>> @@ -100,5 +100,9 @@ TODO: document the other workarounds.
>>          <application name="Rust" executable="rust">
>>              <option name="glsl_zero_init" value="true"/>
>>          </application>
>> +
>> +        <application name="Divinity: Original Sin Enhanced Edition" executable="EoCApp">
>> +            <option name="allow_glsl_extension_directive_midshader" value="true" />
>> +        </application>
>>      </device>
>>  </driconf>
>> --
>> 2.11.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170107/5378af14/attachment.sig>