[Mesa-dev] [PATCH] nir: remove duplicated foreach loop

Jason Ekstrand jason at jlekstrand.net
Tue Jan 10 01:05:36 UTC 2017


Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

and pushed... Thanks!

On Mon, Jan 9, 2017 at 1:45 PM, Thomas Hindoe Paaboel Andersen <
phomes at gmail.com> wrote:

> The foreach loop was called both in the else case
> and right after. The indentation seems to indicate
> that the extra call was from a previous version
> with an else section with out curly brackets.
> ---
> Spotted due to the wrong indentation. The patch is untested
> as I do not have the neccesary hardware.
>
>  src/compiler/nir/nir_from_ssa.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_
> ssa.c
> index 2d8eed5..a8d3e64 100644
> --- a/src/compiler/nir/nir_from_ssa.c
> +++ b/src/compiler/nir/nir_from_ssa.c
> @@ -970,7 +970,6 @@ nir_lower_ssa_defs_to_regs_block(nir_block *block)
>        } else {
>           nir_foreach_dest(instr, dest_replace_ssa_with_reg, &state);
>        }
> -         nir_foreach_dest(instr, dest_replace_ssa_with_reg, &state);
>     }
>
>     return state.progress;
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170109/9f42caa1/attachment.html>


More information about the mesa-dev mailing list