[Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

Jason Ekstrand jason at jlekstrand.net
Wed Jan 11 21:29:50 UTC 2017


On Tue, Jan 10, 2017 at 2:46 AM, Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
>
> On 10 January 2017 at 05:49, Ben Widawsky <benjamin.widawsky at intel.com>
> wrote:
> > On 17-01-09 11:56:04, Jason Ekstrand wrote:
> >> Do we need to do any error checking here?  Do we need to check for the
> >> right dri image extension version?  Do we need to check queryImage !=
> >> NULL?  Do we need to check a return value?
> >>
> >> I ask because I genuinely don't know how this stuff is supposed to work.
> >> Returning a default of 1 seems reasonable.
> >
> > I'm not entirely sure about a reasonable default, 1 seemed right to me,
> but
> > Eric
> > E seemed to think we should return 0, it's hard to test, so I'll defer to
> > anyone
> > that claims to be the expert.
>
> Drivers which don't support the new interfaces can by definition only
> export single-plane images. So, 1.
>

An expert has spoken!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170111/7471ef3e/attachment.html>


More information about the mesa-dev mailing list