[Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

[Daniel Stone]

Hi,

On 10 January 2017 at 10:46, Daniel Stone <daniel at fooishbar.org> wrote:
> On 10 January 2017 at 05:49, Ben Widawsky <benjamin.widawsky at intel.com> wrote:
>>> I ask because I genuinely don't know how this stuff is supposed to work.
>>> Returning a default of 1 seems reasonable.
>>
>> I'm not entirely sure about a reasonable default, 1 seemed right to me, but
>> Eric
>> E seemed to think we should return 0, it's hard to test, so I'll defer to
>> anyone
>> that claims to be the expert.
>
> Drivers which don't support the new interfaces can by definition only
> export single-plane images. So, 1.

You also need to return 1 for if (!bo->image), which breaks cursors otherwise.

Cheers,
Daniel