[Mesa-dev] [PATCH 02/22] intel/blorp_blit: Handle ISL_AUX_USAGE_HIZ

Jason Ekstrand jason at jlekstrand.net
Thu Jan 12 02:50:14 UTC 2017


I would rather not...  Those asserts exist precisely to prevent someone
from doing a blorp copy with HiZ enabled when it's not actually supported.
The right thing to do is to set aux_usage to ISL_AUX_USAGE_NONE if you want
blorp to ignore aux.

On Wed, Jan 11, 2017 at 5:54 PM, Nanley Chery <nanleychery at gmail.com> wrote:

> Prevent assert failures that would occur in the next patch. BLORP
> ignores this flag internally, so no protections are lost here.
>
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/blorp/blorp_blit.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c
> index 1cbd9403c9..aa389dbcc1 100644
> --- a/src/intel/blorp/blorp_blit.c
> +++ b/src/intel/blorp/blorp_blit.c
> @@ -2291,9 +2291,11 @@ blorp_copy(struct blorp_batch *batch,
>        isl_format_get_layout(params.dst.surf.format);
>
>     assert(params.src.aux_usage == ISL_AUX_USAGE_NONE ||
> +          params.src.aux_usage == ISL_AUX_USAGE_HIZ ||
>            params.src.aux_usage == ISL_AUX_USAGE_MCS ||
>            params.src.aux_usage == ISL_AUX_USAGE_CCS_E);
>     assert(params.dst.aux_usage == ISL_AUX_USAGE_NONE ||
> +          params.dst.aux_usage == ISL_AUX_USAGE_HIZ ||
>            params.dst.aux_usage == ISL_AUX_USAGE_MCS ||
>            params.dst.aux_usage == ISL_AUX_USAGE_CCS_E);
>
> --
> 2.11.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170111/7f590f17/attachment.html>


More information about the mesa-dev mailing list