[Mesa-dev] [PATCH 1/2] i965: Select DF type for 64-bit integers on Gen < 8.

Kenneth Graunke kenneth at whitecape.org
Sat Jan 21 03:11:25 UTC 2017


On Friday, January 20, 2017 7:07:31 PM PST Matt Turner wrote:
> Gen8 adds Q/UQ types. We attempted to change the types back to DF in the
> generator (commit c95380c40), but an assertion added in the FP64 series
> (commit e481dcc3) triggers before that code has a chance to execute.
> 
> In fact, using Q/UQ in the IR and then changing to DF in the generator
> would not work in the presence of source modifiers, etc.
> 
> Fixes: d6fcede6 ("i965: Return Q and UQ types for int64 and uint64")
> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp   | 8 ++++----
>  src/mesa/drivers/dri/i965/brw_nir.c        | 6 +++---
>  src/mesa/drivers/dri/i965/brw_nir.h        | 3 ++-
>  src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 5 +++--
>  4 files changed, 12 insertions(+), 10 deletions(-)

Thanks for the quick fire extinguisher usage :)

Series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170120/5f050cd4/attachment.sig>


More information about the mesa-dev mailing list