[Mesa-dev] [PATCH] glx: use correct table offset for glAreTexturesResidentEXT

[Emil Velikov]

On 25 July 2017 at 09:12, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 21.07.2017 16:57, Emil Velikov wrote:
>>
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> The correct offset is 322 as opposed to 332.
>> Broken since the rework of GET_DISPATCH back in ~2012.
>
>
> This is kind of amazing. How did you run into this?
>
Looking at [truly] vendor neutral indirect libGLX, as opposed to the
current solution.

> Maybe add a simple touch test to piglit?
>
Ack, will look into.

> Maybe use _gloffset_AreTexturesResident (from dispatch.h) instead of using a
> magic number?
>
As the offending commit 99fee476a102 says "... can't use
src/mesa/main/dispatch.h ..."

At the same time, the function was moved outside of the python
generator(s) to address a out of bounds access - see commit
13f96c5401f.
Sadly the same issue exists elsewhere - so I'm looking into addressing
that once and for all, and purging the handwritten function.

That's my evil plan ;-)

-Emil