[Mesa-dev] [PATCH 2/2] mesa: do not trigger _NEW_TEXTURE_STATE in glActiveTexture()

[Brian Paul]

On 06/22/2017 06:49 AM, Samuel Pitoiset wrote:
> This looks like useless because gl_context::Texture::CurrentUnit
> is not used by _mesa_update_texture_state() and friends.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/mesa/main/texstate.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c
> index 0a2883fcc69..caad77a1cc2 100644
> --- a/src/mesa/main/texstate.c
> +++ b/src/mesa/main/texstate.c
> @@ -307,8 +307,6 @@ active_texture(GLenum texture, bool no_error)
>         }
>      }
>
> -   FLUSH_VERTICES(ctx, _NEW_TEXTURE_STATE);
> -
>      ctx->Texture.CurrentUnit = texUnit;
>      if (ctx->Transform.MatrixMode == GL_TEXTURE) {
>         /* update current stack pointer */
>

I believe you're correct.  Did you do a piglit run just to be sure?
If so,
Reviewed-by: Brian Paul <brianp at vmware.com>