[Mesa-dev] [PATCH] mesa: fix unused variable warning in release builds

Nicolai Hähnle nhaehnle at gmail.com
Mon Jun 26 08:12:57 UTC 2017


On 26.06.2017 01:25, Timothy Arceri wrote:
> ---
>   src/mesa/main/uniforms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
> index 91c3bf6..1c3d89b 100644
> --- a/src/mesa/main/uniforms.c
> +++ b/src/mesa/main/uniforms.c
> @@ -104,7 +104,7 @@ _mesa_update_shader_textures_used(struct gl_shader_program *shProg,
>      GLbitfield mask = prog->SamplersUsed;
>      gl_shader_stage prog_stage =
>         _mesa_program_enum_to_shader_stage(prog->Target);
> -   struct gl_linked_shader *shader = shProg->_LinkedShaders[prog_stage];
> +   UNUSED struct gl_linked_shader *shader = shProg->_LinkedShaders[prog_stage];

MAYBE_UNUSED is preferred for this. Apart from that:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>


>      GLuint s;
>   
>      assert(shader);
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list