[Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

[Bartosz Tomczyk]

Thanks Nicolai,

Adding Timothy who seems most active on glthread topic.

Guys, do you think we can land this, with above comments addressed?

On Thu, Mar 30, 2017 at 1:40 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:

> On 30.03.2017 10:30, Bartosz Tomczyk wrote:
>
>> Thank you guys for testing.
>>
>> I'll address all issues in next patch if we decide to merge it.
>>
>> Nicolai,
>>
>> Could you comment on _glapi_{get/set}_dispatch part. I'm not
>> familiar with it and I'm not sure if it's correct.
>>
>
> It looks good to me.
>
> Cheers,
> Nicolai
>
>
>> On Thu, Mar 30, 2017 at 5:38 AM, Michel Dänzer <michel at daenzer.net
>> <mailto:michel at daenzer.net>> wrote:
>>
>>     On 30/03/17 02:31 AM, Bartosz Tomczyk wrote:
>>     > Call it directly when batch queue is empty. This avoids costly
>> thread
>>     > synchronisation. With this fix games that previously regressed
>>     > with mesa_glthread=true like xonotic or grid autosport.
>>
>>     The second sentence here is missing a verb (at least).
>>
>>
>>     --
>>     Earthling Michel Dänzer               |
>> http://www.amd.com
>>     Libre software enthusiast             |             Mesa and X
>> developer
>>
>>
>>
>
> --
> Lerne, wie die Welt wirklich ist,
> Aber vergiss niemals, wie sie sein sollte.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170330/35346286/attachment.html>