[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

[Eric Engestrom]

On Tuesday, 2017-10-17 15:26:00 +0000, Kai Wasserbäch wrote:
> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver
> name. This causes confusion, because there is a kernel interface by the
> same name where a version 3 is available.

What confusion? Do you have an example?

I'm not really opposed to a change, but I don't see the benefit,
especially of just adding this "MESA-" prefix...

(Nit: please spell it "Mesa", it's a name, not an acronym :)

> 
> This change attempts to make it clearer that the "dri2" name of the Mesa
> EGL driver has nothing to do with that kernel interface and is rather a
> Mesa internal versioning of an interface.
> 
> See eg. the thread beginning at
> <https://lists.freedesktop.org/archives/amd-gfx/2017-October/014544.html>
> for an example.
> 
> Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
> ---
>  src/egl/drivers/dri2/egl_dri2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 77f09271f0..3991dfc84d 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -3260,7 +3260,7 @@ _eglBuiltInDriver(void)
>     dri2_drv->base.API.GLInteropExportObject = dri2_interop_export_object;
>     dri2_drv->base.API.DupNativeFenceFDANDROID = dri2_dup_native_fence_fd;
>  
> -   dri2_drv->base.Name = "DRI2";
> +   dri2_drv->base.Name = "MESA-DRI2";
>  
>     return &dri2_drv->base;
>  }
> -- 
> 2.14.2
>