[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name
Kai Wasserbäch
kai at dev.carbon-project.org
Tue Oct 17 17:04:07 UTC 2017
Hey Eric,
Eric Engestrom wrote on 17.10.2017 18:31:
> On Tuesday, 2017-10-17 15:26:00 +0000, Kai Wasserbäch wrote:
>> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver
>> name. This causes confusion, because there is a kernel interface by the
>> same name where a version 3 is available.
>
> What confusion? Do you have an example?
>
> I'm not really opposed to a change, but I don't see the benefit,
> especially of just adding this "MESA-" prefix...
well, reading „EGL version string: 1.5 (DRI2)“ when calling eglinfo I assumed
that DRI3 was somehow not working on my setup (see
<https://lists.freedesktop.org/archives/amd-gfx/2017-October/014544.html>, which
I've included in the commit message). Michel then cleared up, that the interface
meant by the EGL version string is an internal Mesa interface which has nothing
to do with the more widely known X11 protocol extension.
So I thought it best to clearly separate them. Ideally this internal interface
wouldn't be called "dri" at all, but I that's probably going a bit too far.
> (Nit: please spell it "Mesa", it's a name, not an acronym :)
Ok, I'll resend in a minute with the correction to the commit message Michel
pointed out.
Cheers,
Kai
>> This change attempts to make it clearer that the "dri2" name of the Mesa
>> EGL driver has nothing to do with that kernel interface and is rather a
>> Mesa internal versioning of an interface.
>>
>> See eg. the thread beginning at
>> <https://lists.freedesktop.org/archives/amd-gfx/2017-October/014544.html>
>> for an example.
>>
>> Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171017/c8fe6b1b/attachment.sig>
More information about the mesa-dev
mailing list