[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

[Emil Velikov]

On 17 October 2017 at 18:04, Kai Wasserbäch <kai at dev.carbon-project.org> wrote:
> Hey Eric,
> Eric Engestrom wrote on 17.10.2017 18:31:
>> On Tuesday, 2017-10-17 15:26:00 +0000, Kai Wasserbäch wrote:
>>> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver
>>> name. This causes confusion, because there is a kernel interface by the
>>> same name where a version 3 is available.
>>
>> What confusion? Do you have an example?
>>
>> I'm not really opposed to a change, but I don't see the benefit,
>> especially of just adding this "MESA-" prefix...
>
> well, reading „EGL version string: 1.5 (DRI2)“ when calling eglinfo I assumed
> that DRI3 was somehow not working on my setup (see
> <https://lists.freedesktop.org/archives/amd-gfx/2017-October/014544.html>, which
> I've included in the commit message). Michel then cleared up, that the interface
> meant by the EGL version string is an internal Mesa interface which has nothing
> to do with the more widely known X11 protocol extension.
>
> So I thought it best to clearly separate them. Ideally this internal interface
> wouldn't be called "dri" at all, but I that's probably going a bit too far.
>
Yes name is a bit misleading, so I'm wondering if any of the following
won't be better
 - s/DRI2/DRI/ - might be tad confusing
 - emit the corresponding DRI2 vs DRI3 - ideally, but might be fiddly
to get sorted
 - drop DRI2 all together - the other backends (glx yes glx and
gallium) are long gone

What do you guys think?
Emil