[Mesa-dev] [PATCH] mesa/mtypes: reback gl_shader_program_data.

[Thomas Helland]

Typo in commit subject. s/reback/repack.
With that fixed this has my RB.
A nice side-effect is that this now fits in two cachelines =)

2017-09-03 13:12 GMT+02:00 Dave Airlie <airlied at gmail.com>:
> From: Dave Airlie <airlied at redhat.com>
>
> This reduces the size from 144 bytes to 128 bytes.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/mesa/main/mtypes.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 2dab594..d44897b 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -2853,9 +2853,9 @@ struct gl_shader_program_data
>     struct gl_uniform_storage *UniformStorage;
>
>     unsigned NumUniformBlocks;
> -   struct gl_uniform_block *UniformBlocks;
> -
>     unsigned NumShaderStorageBlocks;
> +
> +   struct gl_uniform_block *UniformBlocks;
>     struct gl_uniform_block *ShaderStorageBlocks;
>
>     struct gl_active_atomic_buffer *AtomicBuffers;
> @@ -2873,13 +2873,13 @@ struct gl_shader_program_data
>      * lands we should switch to using the cache_fallback support.
>      */
>     bool skip_cache;
> +   GLboolean Validated;
>
>     /** List of all active resources after linking. */
>     struct gl_program_resource *ProgramResourceList;
>     unsigned NumProgramResourceList;
>
>     enum gl_link_status LinkStatus;   /**< GL_LINK_STATUS */
> -   GLboolean Validated;
>     GLchar *InfoLog;
>
>     unsigned Version;       /**< GLSL version used for linking */
> --
> 2.9.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev