[Mesa-dev] [PATCH 01/10] i965/screen: Add basic support for rendering 10 bpc/depth 30 framebuffers.

[Emil Velikov]

On 9 September 2017 at 13:06, Mario Kleiner <mario.kleiner.de at gmail.com> wrote:
>
>
> On 09/07/2017 04:27 PM, Emil Velikov wrote:
>>
>> Hi Mario,
>>
>> On 5 September 2017 at 06:01, Mario Kleiner <mario.kleiner.de at gmail.com>
>> wrote:
>>>
>>> Expose formats which are supported at least back to Gen 5 Ironlake,
>>> possibly further. Allow creation of 10 bpc winsys buffers for drawables.
>>>
>>> glxinfo now lists new RGBA 10 10 10 2/0 formats.
>>> Works correctly under DRI2 without compositing.
>>>
>> In all fairness I did not expect apps to _not_ get confused by the
>> extra config(s).
>> Barring g-s (workaround in 8/10), have you seen any other apps that
>> exhibit problems?
>
>
> So far not. DE's work, glxgears/es2gears, weston demos, my app, glmark are
> fine.
>
>> Say any steam games or SDL based apps?
>
>
> I don't have access to any Steam games. neverball/neverputt is Opengl SDL-2
> based and those work, both on X11 and Weston. I can nicely see color
> gradients in neverputt becoming smooth in 30 bit mode when they have some
> steps in 24 bit mode.
>
Ack. Tim, Nicolai would you guys have the chance to the series on a few games?
I'd wait for v2 though or as it hits master.

Mario as your series lands you might want to take Valve on their kind offer [1].

[1] https://lists.freedesktop.org/archives/dri-devel/2015-April/081045.html

>> ARRAY_SIZE() further down, will need a tweak.
>
>
> This i don't understand? ARRAY_SIZE seems to be generic enough to not need
> tweaks based on the arrays content?
>
Skimming through commit 731ba6924a2ed6cdf47a78fd637a91a19ddcf9ed
should clear the confusion.
Admittedly approach used there is a bit fragile and we could rework it
like your patch 7/10.

-Emil