[Mesa-dev] [PATCH 00/11] GL_EXT_gpu_shader4

[Ian Romanick]

On 08/07/2018 10:41 PM, Marek Olšák wrote:
> Hi,
> 
> This adds EXT_gpu_shader4 with its subset EXT_texture_buffer_object.
> 
> Some applications that previously required force_glsl_version=130 now
> work without it, because EXT_gpu_shader4 enables a subset of GLSL 1.30.
> 
> There are also applications that need the old-style texture functions
> from EXT_gpu_shader4.
> 
> I have some tests internally. I'm not sure I wanna write piglits for
> everything (there are about 360 texture functions). A lot of the code
> is shared with GLSL 1.30 anyway.

There need to at least be compile tests for all of them.  It should be
too much effort to write a Python script that generates a few tests that
try a bunch of them at once.  Compile tests for some of the other stuff
wouldn't hurt either.  It seems like every time we think adding a
billion functions or operators will without tests will be fine, we miss
one or two somehow.

It also looks like GL_EXT_gpu_shader4 adds a bunch of glFooEXT functions
that are probably all aliases for the glFoo functions in OpenGL 3.0...
are those already wired up?

> The only special additions are "unsigned int" and "truncate".

Testing the new constructor syntax and the associated array constructor
syntax shouldn't require much effort.  It also shouldn't be hard to
modify the trunc() tests to be truncate() tests.

> The following GLSL code compiles successfully, even though
> the "unsigned int" constructor looks weird.
> 
>     unsigned int x = unsigned int(gl_Vertex.x);
>     unsigned int y = 0u;
>     gl_FrontColor.x = truncate(float(x + y));
> 
> Please review.
> 
> Thanks,
> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>