[Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)
airlied at gmail.com
Mon Jul 23 07:13:51 UTC 2018
On 23 July 2018 at 16:46, Gert Wollny <gert.wollny at collabora.com> wrote:
> Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie:
>> > > + uint32_t max_shader_buffer = shader == PIPE_SHADER_FRAGMENT ?
>> > > + rs->caps.caps.v2.max_shader_buffer_frag_compute :
>> > Shouldn't max_shader_buffer_frag_compute also be used for
>> > PIPE_SHADER_COMPUTE?
>> virgl doesn't support compute shaders yet. Adding support for them is
>> in the future patches.
> I somehow suspected this, but then one should probably explicitely
> return zero instead of returning max_shader_buffer_other_stages.
You can never reach this point of code with shader set to PIPE_SHADER_COMPUTE.
The outer switch statement defaults to return 0 for compute shaders.
More information about the mesa-dev