[Mesa-dev] [PATCH 0/2] r600: Fix array texture slice index evaluation

[Gert Wollny]

Am Montag, den 25.06.2018, 15:54 +1000 schrieb Dave Airlie:
> /home/airlied/devel/piglit/bin/textureGather fs nonconst r 0 float
> 2DArray repeat
> 
> amongst others appears to regress with these two.

I can confirm this. From which piglit subset is this? I ran the shader
subset and didn't see this. 

When I don't add the 0.5 to the z coordinate in the shader for 
FETCH_OP_GATHER4_O then above thest passes again, even though the
rounding mode is still set to TRUNC (which i find kind of surprising).

I'll do a bit more checking  and prepare a new patch set. 

Thanks for testing, 
Gert  

> 
> Dave.
> 
> 
> On 22 June 2018 at 19:37, Gert Wollny <gert.wollny at collabora.com>
> wrote:
> > these two patches correct the offets and the rounding modes for the
> > index evaluation when accessing texture arrays. The patches were
> > tested
> > with the gles3 test suite where they fix a number of tests related
> > to 2D
> > texture arrays and didn't show any regressions.
> > 
> > Best,
> > Gert
> > 
> > Gert Wollny (2):
> >   r600: correct texture offset for array index lookup
> >   r600: set rounding mode for texture array layer selection
> > 
> >  src/gallium/drivers/r600/evergreen_state.c | 21 ++++++++++
> >  src/gallium/drivers/r600/r600_shader.c     | 64
> > +++++++++++++++++++++++++++++-
> >  2 files changed, 84 insertions(+), 1 deletion(-)
> > 
> > --
> > 2.16.4
> >