[Mesa-dev] Thoughts after hitting 100 merge requests?

[Pekka Paalanen]

On Sat, 12 Jan 2019 12:10:42 +0100
apinheiro <apinheiro at igalia.com> wrote:

> 
> On 11/1/19 18:05, Jason Ekstrand wrote:
> >  5. There's no way with gitlab for Reviewed-by tags to get
> > automatically applied as part of the merging process.  This makes
> > merging a bit more manual than it needs to be but is really no worse
> > than it was before.  
> 
> 
> Well, I would say that it slightly worse. For small series, it is true
> that I manually added the Rb when I got a review. But for big series,
> when it got reviewed, I used patchwork to get back the series, but with
> the Rb in place.

Hi,

I thought I'd share a couple of scripts I tend to use:

$ git append-message origin/master..HEAD

will open an editor and add anything you write to the end of all the
commits in the given range on the current branch. Nice for adding R-b
tags in a batch to the whole branch.


$ git fetch-mr 77
$ git fetch-mr origin 77

both will fetch the MR number 77 from the remote "origin" as a new
local branch "mr-origin-77", and if such named branch already exists,
the old one gets renamed to "mr-origin-77-old". It will abort if the
-old branch already exists as well.

I do much of my patch review in gitk and my editor, so fetching the MR
branch is useful. Since I have the -old branch, I can very easily see
what changed compared to the last time I reviewed it.


HTH,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: git-append-message
Type: application/octet-stream
Size: 900 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190130/691e2fb5/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: git-fetch-mr
Type: application/octet-stream
Size: 256 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190130/691e2fb5/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190130/691e2fb5/attachment.sig>