[Mesa-dev] [PATCH] panfrost: bifrost: Fix format string in disassembler

[Ryan Houdek]

Awesome, thanks for the fix.
Reviewed-By: Ryan Houdek <Sonicadvance1 at gmail.com>

On Tue, Jun 4, 2019 at 11:55 PM Tomeu Vizoso <tomeu.vizoso at collabora.com>
wrote:

> The compiler configuration was hardened to fail on format warnings and
> things stopped building.
>
> Fixes: c9c1e2610647 ("mesa: prevent common string formatting security
> issues")
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> ---
>  src/gallium/drivers/panfrost/bifrost/disassemble.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/panfrost/bifrost/disassemble.c
> b/src/gallium/drivers/panfrost/bifrost/disassemble.c
> index daadf2578965..03ade19a689d 100644
> --- a/src/gallium/drivers/panfrost/bifrost/disassemble.c
> +++ b/src/gallium/drivers/panfrost/bifrost/disassemble.c
> @@ -2195,7 +2195,7 @@ bool dump_clause(uint32_t *words, unsigned *size,
> unsigned offset, bool verbose)
>
>          if (verbose) {
>                  for (unsigned i = 0; i < num_consts; i++) {
> -                        printf("# const%d: %08lx\n", 2 * i, consts[i] &
> 0xffffffff);
> +                        printf("# const%d: %08" PRIx64 "\n", 2 * i,
> consts[i] & 0xffffffff);
>                          printf("# const%d: %08" PRIx64 "\n", 2 * i + 1,
> consts[i] >> 32);
>                  }
>          }
> --
> 2.20.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190605/cf337ec4/attachment.html>