[Mesa-dev] [PATCH 2/2] radv: ignore inline uniform blocks in radv_CmdPushDescriptorSetKHR()

Józef Kucia joseph.kucia at gmail.com
Tue Jun 11 10:31:59 UTC 2019

On Tue, Jun 11, 2019 at 12:19 PM Samuel Iglesias Gonsálvez
<siglesias at igalia.com> wrote:
> Right, it should be detected by the Validation Layers. However it is
> arguable what to do in the driver's side. We can just keep it as it is
> now, ignore inline uniform block updates (this patch) or even add an
> assert if it affects stability of the HW (it is not the case here, we
> tested it). I think ignoring the updates it's the best option, but I am
> OK with what RADV developers prefer to do.

IMHO the code should be left as it is. An assert could be a good
addition, but an additional bool parameter only for handling invalid
usage doesn't seem right.

More information about the mesa-dev mailing list