[Mesa-dev] [Bug 110923] Multiple VkSubpassDependency-entries with the same dstSubpass not handled correctly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110923

            Bug ID: 110923
           Summary: Multiple VkSubpassDependency-entries with the same
                    dstSubpass not handled correctly
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Vulkan/radeon
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: chris.forfang at gmail.com
        QA Contact: mesa-dev at lists.freedesktop.org

Looking at [1], it seems like if VkRenderPassCreateInfo->pDependencies has
multiple entries with the same value for dstSubpass then each entry will
overwrite the effects of the previous.

Take [2] as an example; in this case
pass->subpasses[0].start_barrier.src_stage_mask appears to end up as
pDependencies[1].srcStageMask instead of the seemingly correct
(pDependencies[0].srcStageMask | pDependencies[1].srcStageMask).

In other words, as the entries in pDependencies are considered the masks should
be OR-ed, not assigned.

[1]
https://github.com/intel/external-mesa/blob/a749ad9d7d8558c8b085e0484a91d83ca84d9db2/src/amd/vulkan/radv_pass.c#L366
[2]
https://github.com/KhronosGroup/Vulkan-Tools/blob/b99797641e8275e31557b3eb0610e9d282f96c35/cube/cube.c#L1896

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190614/dcf233f8/attachment.html>