[Mesa-dev] [PATCH] radv: disable viewport clamping even if FS doesn't write Z

[Juan A. Suarez Romero]

On Tue, 2019-06-18 at 18:58 +0200, Samuel Pitoiset wrote:
> This fixes new CTS dEQP-VK.pipeline.depth_range_unrestricted.*.
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_pipeline.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 


could this patch be a candidate for stable release?


	J.A.

> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index 8bc0d9b53e6..765f6105f7d 100644
> --- a/src/amd/vulkan/radv_pipeline.c
> +++ b/src/amd/vulkan/radv_pipeline.c
> @@ -2788,8 +2788,7 @@ radv_pipeline_generate_depth_stencil_state(struct radeon_cmdbuf *ctx_cs,
>  	db_render_override |= S_02800C_FORCE_HIS_ENABLE0(V_02800C_FORCE_DISABLE) |
>  			      S_02800C_FORCE_HIS_ENABLE1(V_02800C_FORCE_DISABLE);
>  
> -	if (!pCreateInfo->pRasterizationState->depthClampEnable &&
> -	    ps->info.info.ps.writes_z) {
> +	if (!pCreateInfo->pRasterizationState->depthClampEnable) {
>  		/* From VK_EXT_depth_range_unrestricted spec:
>  		 *
>  		 * "The behavior described in Primitive Clipping still applies.