[Mesa-dev] [PATCH] panfrost: Maintain a whitelist of supported GPU's

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Mon Jun 24 15:20:11 UTC 2019


> +        if (!supported_gpu) {
> +                fprintf(stderr, "Unsupported GPU\n");
> +                free(screen);
> +                return NULL;
> +        }

End users may see this. Is it better to silently fail or to print a
message that Panfrost isn't loaded (either way, the swrast would
probably load in its place).

> +static const panfrost_supported_gpus[] = {
> +        0x0750,
> +        0x0820,
> +        0x0860
> +};

Please add a comment to each line with the commercial name of the
respective GPU. (e.g. "/* Mali T760 */")
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190624/9fc7f16e/attachment.sig>


More information about the mesa-dev mailing list