[Mesa-dev] [PATCH] gbm: add gbm_{bo, surface}_create_with_modifiers2

Simon Ser contact at emersion.fr
Tue Jun 25 06:26:12 UTC 2019

> > +struct gbm_bo *
> > +gbm_bo_create_with_modifiers2(struct gbm_device *gbm,
> > +                              uint32_t width, uint32_t height,
> > +                              uint32_t format,
> > +                              const uint64_t *modifiers,
> > +                              const unsigned int count,
> > +                              uint32_t flags);
> Declaration here says 'flags' while definition says 'usage'.

Yeah, I tried to be consistent with gbm_bo_create, which sometimes uses
flags and sometimes usage.

I'm not sure which terminology is better. I guess flags would be more
appropriate since the enum is called gbm_bo_flags?

> I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
> have usage at first but it was removed during the review. I'm having
> trouble digging what was the reason for this?

I'm not sure either. Daniel said it was a mistake.

Adding the 63bd2ae7452d4 folks to the discussion. Ben, do you remember
the details?

More information about the mesa-dev mailing list