[Mesa-dev] [PATCH] gbm: add gbm_{bo, surface}_create_with_modifiers2

Daniel Stone daniel at fooishbar.org
Tue Jun 25 09:02:55 UTC 2019


On Tue, 25 Jun 2019 at 07:26, Simon Ser <contact at emersion.fr> wrote:
> > I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
> > have usage at first but it was removed during the review. I'm having
> > trouble digging what was the reason for this?
> I'm not sure either. Daniel said it was a mistake.
> Adding the 63bd2ae7452d4 folks to the discussion. Ben, do you remember
> the details?

We decided to remove it since we decided that modifiers were a good
enough proxy for usage; no need to pass SCANOUT or TEXTURE anymore,
because we already get the scanout modifiers from KMS and the texture
modifiers from EGL.

In hindsight, I think this was a mistake since it only handles buffer
layout, and not buffer placement or cache configuration.


More information about the mesa-dev mailing list