[Mesa-dev] What does WIP really mean in an MR?

Rob Clark robdclark at gmail.com
Sat Jun 29 00:30:00 UTC 2019

I had interpreted it as literally the "block the gitlab merge button"
option, ie. "I want to get feedback but it is not ready to merge and
I'll drop the WIP tag when I think it is"..

(comments inline)

On Fri, Jun 28, 2019 at 5:12 PM Ian Romanick <idr at freedesktop.org> wrote:
> After a conversation yesterday with a couple of the other Intel devs,
> I've come to the conclusion that *everyone* interprets WIP to mean
> something different.  I heard no less than four interpretations.
> * This series is good.  It hasn't been reviewed, so don't click "merge."

isn't that the point of a MR.. doesn't seem like a reason for "WIP"

> * This series has some sketchy bits.  It probably isn't ready for review
> unless you've been tagged for design feedback.

I guess I'd also use WIP for "I want some early feedback, but it isn't
ready yet".. but in this case I'd also poke people who I wanted to
look at it

> * This series has been reviewed.  Incorporation of detailed feedback is
> in progress, but it's going to take some time.

I suppose also a case for "WIP"..

> * This series is good, but there are some questionable patches at the end.

I guess in this case, I'd reform things into multiple MR's, one with
the parts ready to go, and one w/ the remaining WIP bits


> Due to this lack of common understanding, we discovered at least one MR
> that was ready to go but had been ignored for months. :(  This makes me
> wonder if other MRs have similarly languished for no good reason.
> Can we formulate some guidelines for how people should apply WIP to
> their MRs and how people should interpret WIP when they see it on an MR?
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

More information about the mesa-dev mailing list