[Mesa-stable] [PATCH] radv: emit a cache flush before enabling predication

[Dave Airlie]

On 26 Jan. 2018 01:10, "Matthew Nicholls" <mnicholls at feralinteractive.com>
wrote:

Otherwise cache flushes could get conditionally disabled while still
clearing
the flush_bits, and thus flushes due to application pipeline barriers may
never
get executed.


I wonder would we better not predicating flushes. I added that as an extra
opt, but it might be the wrong move.

Dave.


Cc: mesa-stable at lists.freedesktop.org
---
 src/amd/vulkan/radv_meta_fast_clear.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/amd/vulkan/radv_meta_fast_clear.c
b/src/amd/vulkan/radv_meta_fast_clear.c
index fdeeaeedbf..f4353fd889 100644
--- a/src/amd/vulkan/radv_meta_fast_clear.c
+++ b/src/amd/vulkan/radv_meta_fast_clear.c
@@ -602,6 +602,8 @@ radv_emit_color_decompress(struct radv_cmd_buffer
*cmd_buffer,
        }

        if (!decompress_dcc && image->surface.dcc_size) {
+               si_emit_cache_flush(cmd_buffer);
+
                radv_emit_set_predication_state_from_image(cmd_buffer,
image, true);
                cmd_buffer->state.predicating = true;
        }
--
2.13.6
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20180126/7771c577/attachment-0001.html>