[PATCH] iface-modem-3gpp: add SubscriptionState property

Aleksander Morgado aleksander at lanedo.com
Sat Sep 28 07:44:35 PDT 2013


On 28/09/13 07:13, Dan Williams wrote:
>> This patch adds a new property, SubscriptionState, to
>> > org.freedesktop.ModemManager1.Modem.Modem3gpp.  The subscription state
>> > is used to indicate whether an account has been provisioned, and if so,
>> > whether the account has any data left.
>> > 
>> > There will be two subsequent patches that will make use of this new property.
> There seems to be some conceptual overlap with the 3gpp2
> MMModemCdmaActivationState, perhaps this property could instead be a
> generic Modem interface property instead, and the 3GPP2 stuff could
> update both ActivateState and the generic SubscriptionStatus property
> from the same data?
> 
> Or are there potentially more 3GPP states for the subscription than what
> you've defined here?

Do you really think it's a good idea to merge these? If the 3GPP ones
are 'unprovisioned', 'provisioned-with-data' and
'provisioned-data-exhausted'; they really have not much to do with the
3GPP2 ones. Also, I understand that not-yet-activated accounts in 3GPP2
may be normal (e.g. when you buy a new device); but I don't think that's
the case in 3GPP.

-- 
Aleksander


More information about the ModemManager-devel mailing list